feat(analysis): sort, pagination, sticky header for query result table (#539)#655
Merged
cct08311github merged 4 commits intodotnet8from Mar 19, 2026
Merged
Conversation
cct08311github
force-pushed
the
feat/analysis-layui-table-539
branch
from
5c3d14b to
f8cbdc9
Compare
Merged
5 tasks
cct08311github
force-pushed
the
feat/analysis-layui-table-539
branch
from
f8cbdc9 to
aa5ef6c
Compare
…ange IProgress<ImportProgress>? parameter was added as optional default in BaseImportVM.BatchSaveData. Five demo FrameworkUserImportVM overrides lacked the matching signature, causing CS0115 build errors. Fixes CI build failures on dotnet8 and PR #655. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
3 tasks
cct08311github
force-pushed
the
feat/analysis-layui-table-539
branch
from
aa5ef6c to
d837cd4
Compare
The BlazorDemo.Client (Microsoft.NET.Sdk.BlazorWebAssembly) requires the
wasm-tools workload for the browser-wasm RID. GitHub Actions runners now
ship with .NET 10 preinstalled; without a global.json the newer SDK can
be selected, causing NETSDK1082 ("no runtime pack for browser-wasm").
Changes:
- Add `dotnet workload install wasm-tools` step before dotnet restore
- Add global.json to pin SDK to 8.0.x (latestFeature rollForward)
Fixes CI build-and-test failures on dotnet8 and PR #655.
https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
cct08311github
force-pushed
the
feat/analysis-layui-table-539
branch
from
d837cd4 to
135e73b
Compare
DOTNET_ROOT points to /usr/share/dotnet (system location), so workload packs must be installed there (with sudo) to be found during the build step. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM
…lt table (#539) - Wrap result table in `.analysis-table-wrap` div for CSS sticky-header support - Add client-side column sorting: click header to cycle asc → desc → original Sort indicator uses CSS `::after` so `th.textContent` is unchanged (preserves all existing header-text tests) - Add pagination (50 rows/page) with page-info span and prev/next buttons; pagination div only rendered when row count exceeds page size - Sorting resets to first page; % share columns remain non-sortable - Add 29 new Jest tests covering wrapper, sort (asc/desc/reset/multi-col/string), and pagination (no-div ≤50, div >50, page info, next, prev-disabled, sort reset) - 344 Jest tests pass total Closes #539 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
cct08311github
force-pushed
the
feat/analysis-layui-table-539
branch
from
135e73b to
75094c4
Compare
cct08311github
added a commit
that referenced
this pull request
Mar 19, 2026
* fix(demo): update BatchSaveData override signatures after #607 API change IProgress<ImportProgress>? parameter was added as optional default in BaseImportVM.BatchSaveData. Five demo FrameworkUserImportVM overrides lacked the matching signature, causing CS0115 build errors. Fixes CI build failures on dotnet8 and PR #655. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM * fix(ci): install wasm-tools workload + pin .NET 8 SDK via global.json The BlazorDemo.Client (Microsoft.NET.Sdk.BlazorWebAssembly) requires the wasm-tools workload for the browser-wasm RID. GitHub Actions runners now ship with .NET 10 preinstalled; without a global.json the newer SDK can be selected, causing NETSDK1082 ("no runtime pack for browser-wasm"). Changes: - Add `dotnet workload install wasm-tools` step before dotnet restore - Add global.json to pin SDK to 8.0.x (latestFeature rollForward) Fixes CI build-and-test failures on dotnet8 and PR #655. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM * fix(ci): use sudo for wasm-tools workload install DOTNET_ROOT points to /usr/share/dotnet (system location), so workload packs must be installed there (with sudo) to be found during the build step. https://claude.ai/code/session_017r2EfWhoDdvECdoncQg6xM --------- Co-authored-by: Claude <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<table>in.analysis-table-wrapdiv; CSS providesposition: stickyon<thead>headers withmax-height: 420px / overflow-y: auto::after(soth.textContentis unchanged — all 15+ existing header-text tests continue to pass)Implementation notes
th.dataset.sortDircarries the current sort direction (''/'asc'/'desc'); CSS[data-sort-dir="asc"]::afterprovides the ▲/▼ indicator without touchingtextContentTest plan
npm testintest/WalkingTec.Mvvm.Js.Tests— 344 tests passrenderTabletests unmodified and greenCloses #539
🤖 Generated with Claude Code